Sigil: City of Doors

Two changes today.

1) Fix for store in Golden Bariaur - no longer purchases items from players. Was purchasing items for full price. If you took advantage of this, then you are naughty and if we see anyone with excessive jink, we will cross check the dates and if it was obtained during the last few days, we will roll back your character.

2) Modified the OOC room portal script (that checks for illegal items) to also check for temporary properties stuck on items. Hopefully this will at least partially resolve the Eladrin bonus properties problem and also problems with spells that get stuck as well.

2) it also reintroduced the inventory items limit (grrrr >:( )

Er_Nano_Infame,Jan 13 2015 wrote: 2) it also reintroduced the inventory items limit (grrrr >:( )

There has always been a limit.

What it may have done is reduced that limit due to extra code in the is_legal script that now checks for temporary item properties and strips them.

I think i know why it might have become less optimized, although i find it a little strange.

The original version of a function would check each item for a whole range of illegal properties. This used a hardcoded call, but made that call multiple times, once per item property we wanted to check.

Since i was iterating through all the properties individually anyway, to check for temporary properites, i simply added a case statement to check for the illegal properties at the same time and removed the hardcode function checks.

Looks like the hardcode routines are a lot more optimized than the scripted function calls. So despite my code on paper being more efficient, its probably using more instructions behind the scenes.

Therefore reducing the limit.

The limit is only because of an overflow in how many items can be iterated though, atleast that's what I concluded with when I first encountered it years ago. Something about the iterator only returning integer of some sort which had a very low maximum.

I always understood it to be a TMI overflow issue or a timeout issue. I could be wrong of course.